Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re: Re: Reading

by mkmcconn (Chaplain)
on Feb 06, 2001 at 05:11 UTC ( [id://56576]=note: print w/replies, xml ) Need Help??


in reply to Re: Reading
in thread Reading from ls-lrt (was: Reading)

opendir DIR,$dir || die "Couldn't open '$dir': $!";

For the main point of your code, I think it's excellent the way that you've used sort() on stat() .
  But, I hope it's helpful to point out that the opendir() statement is broken, as it was written at the time of my response, because it tests $dir for Truth rather than opendir() , and that's not what you want.

To use the perlop '||' with opendir() the parentheses are not optional. Otherwise, use or which is more reliable in statements such as open() and opendir() , because the precedence of or is so low that it doesn't even require those pesky parentheses.

(deleted my own bad -here)

But, as I said, this is a small tweak that shouldn't take away from what seems to me otherwise to be a good idea.


mkmcconn

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://56576]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others about the Monastery: (3)
As of 2024-04-25 17:37 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found