for $i (@phrase) {
    $wordfreq{"$phrase[ $j ]"}++;
#    print "$wordfreq{\"$phrase[ $j ]\"} appears $wordfreq{\"$phrase[ 
+$j ]\"}\n";
    $j++;
}
[download]

As for your "trouble formatting the report", maybe you should print some newlines or something.

for my $word (keys %wordfreq) {
  print "$word appears $wordfreq{$word} times\n";
}
[download]

Thanks for the help. Makes total sense now.

You seem to be stepping through the contents of @phrase with an i-based for loop, yet you're referring to the jth element in @phrase. You need to make up your mind ... are you iterating through @phrase with i or with j?

I think either of these (untested) would do what you want:

foreach (@phrase) {
  $wordfreq{$_}++;
}
[download]

or this:

for (my $i=0;$i<=$#phrase;$i++) {
  $wordfreq{$phrase[$i]}++;
}
[download]

Why
for (my $i=0;$i<=$#phrase;$i++)
over the equally efficient yet much more readable
for my $i (0 .. $#phrase)

over the equally efficient ...

i think a "foreach loop" is more efficient, but maybe i'm making a mistake in my benchmark?

perl -wle'
use Benchmark;
my $max = $ARGV[0];
timethese($ARGV[1]||-1, {
  for     => sub { for (my $i=0;$i<$max;$i++) { 1 } },
  foreach => sub { for my $i (0..$max-1)      { 1 } },
}
)' 10000 2000

Benchmark: 
timing 2000 iterations of
 for, foreach
...

       for:  8 wallclock secs ( 7.63 usr +  0.00 sys =  7.63 CPU) @ 26
+2.12/s (n=2000)

   foreach:  5 wallclock secs ( 5.38 usr +  0.00 sys =  5.38 CPU) @ 37
+1.75/s (n=2000)
[download]

No good reason ... personal style (or lack thereof), "that's the way I originally learned it", etc. Thanks for reminding me (and the OP) of a better alternative. :)

 
for my $elem (@phrase) { 
    $wordfreq{$elem}++;
}
[download]

# or even shorter, but perhaps a bit unreadable:
$wordfreq{$_} for (@phrase);
[download]

$wordfreq{$_}++ for (@phrase);
[download]

foreach my $key (sort keys %wordfreq) {
    print "$key: $wordfreq{$key}\n";
}
[download]

# or even shorter, but perhaps a bit unreadable:
$wordfreq{$_} for (@phrase);
[download]

I think perhaps you meant:

$wordfreq{$_}++ for (@phrase);
[download]

Since, after all, it's supposed to count the frequency of each word :)



--chargrill

---

s**lil*;  $*=join'',sort split q**;  s;.*;grr; &&s+(.(.)).+$2$1+; $; =
qq-$_-;s,.*,ahc,;$,.=chop for split q,,,reverse;print for($,,$;,$*,$/)
[download]

Ok, so what are you trying to get it to do? What we have here is what you have tried, and the concept that "it didn't work." What we're missing is what you're expecting it to do and/or what you're hoping to get it to do.

First off you don't need to put parens around your variables. And what is going wrong is you're trying to look up values from @phrase, when you don't need to. Here is how I would write this, following your style:

use strict; 
use warnings; 
my @phrase = ( 'apple', 'apple', 'banana', 'banana', pear', 'pear',
'kiwi', 'kiwi' ); 
my %wordfreq; 

# Here $i contains the actual value from @phrase 
foreach my $i ( @phrase ) { 
     $wordfreq{$i}++; 
     print "$i appears ", $wordfreq{$i}, "\n"; 
}
[download]

Did you really mean to put your print statement in the foreach my $i ( @phrase ) { ... } loop? I think you are going to get eight lines of running total information like

apple appears 1
apple appears 2
banana appears 1
banana appears 2
pear appears 1
pear appears 2
kiwi appears 1
kiwi appears 2
[download]

rather than a summary of the word frequencies. To get a summary you could do something like

print qq{$_ appears $wordfreq{$_} times\n}
   for sort keys %wordfreq;
[download]

after the foreach loop.

Cheers,

JohnGG

Good catch! Sorry, was hurrying to finish up that post before I had to run out the door.

Frank Wiles <frank@revsys.com>
www.revsys.com