Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

Re: Coding styles using if/else

by EvanCarroll (Chaplain)
on Apr 05, 2007 at 22:49 UTC ( [id://608565]=note: print w/replies, xml ) Need Help??


in reply to Coding styles using if/else

I think this is still not as good style as it could be, personally I don't like if/else for debugging as it apears convoluted to me, I would think this would be better: 
exit "Sorry, name can't be empty"
  if $name eq ''
;

print "Thank you, $name. Your submission is complete.";

[download]
IMHO printing for an error message is bad practice, let a function or a module take care of it, and exit (or better yet die, or croak) with a code or a message.

UPDATE
I didn't know exit() was CORE:: -- news to me. use die instead as said below, I thought this was a user func.



Evan Carroll
www.EvanCarroll.com

Replies are listed 'Best First'.
Re^2: Coding styles using if/else
by shmem (Chancellor) on Apr 05, 2007 at 23:09 UTC
    You wrote
    I would think this would be better: 
    exit "Sorry, name can't be empty"
  if $name eq ''
;

    [download]

    It's not, as per perldoc -f exit

    exit EXPR
    exit Evaluates EXPR and exits immediately with that value. Example:
    ...

    Your code does exit 0 if $name eq '' which may or may not be what is intended, but what looks like a message being printed - isn't. Try at your shell 

    perl -e 'exit "foo"'; echo $?

    [download]

    --shmem 

    _($_=" "x(1<<5)."?\n".q·/)Oo.  G°\        /
                              /\_¯/(q    /
----------------------------  \__(m.====·.(_("always off the crowd"))."·
");sub _{s./.($e="'Itrs `mnsgdq Gdbj O`qkdq")=~y/"-y/#-z/;$e.e && print}
[reply]
[d/l]
[select]
      For this kind of usage, with an error message, he should use die instead of exit.
[reply]

In Section Seekers of Perl Wisdom

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?

www.com | www.net | www.org
Node Status?
node history
Node Type: note [id://608565]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? • Last hour • Other CB clients
Other Users?
Others romping around the Monastery: (5)
As of 2024-04-19 11:58 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found