• Updated 12-17-07: Added a refresh link to the XP Nodelet (click the @ to get a refreshed count of votes)
• Updated 12-15-07: removed the need for javascript in a big string, fixed issues with voting booth and picked some better XPath's.
• Updated 12-14-07: fix error with parent_node_id that caused it to be detected as a bot
• Updated 12-13-07: use local XMLHttpRequest objects and removed extraneous code.

Maybe I'm wrong, but I see that you are using global xmlHttpReq objects in asynchronous requests. This could lead into problems, because a second (and successive) asynchronous request (i.e. a second vote in the page) will overwrite previous ones if they are not finished and you'll never receive a response from them.

There are some ways of solving this, for example, putting multiple xmlHttpReq objects in an array.

Sorry if I misread your code

citromatik

Thanks for that catch, I updated the code to use local variables, some testing shows that this works now. Guess I never though of anyone voting that fast!


___________
Eric Hodges

Greasemonkey isn't needed since PerlMonks already allows you to inject HTML and scripts via the Free Nodelet. Perhaps I'll take a stab at converting the code next week.

Updated 12-17-07: Added a refresh link to the XP Nodelet (click the @ to get a refreshed count of votes)


___________
Eric Hodges

Is there any way to use something like this, but without one-click voting? That is, I'd like to be able to change my mind about the vote, and only submit it when I click on the vote button at the end of the page.

That is, I'd like to be able to change my mind about the vote, and only submit it when I click on the vote button at the end of the page.

I agree -- strange as it may sound.

If I end up at a node that I think is correct, I may signify my intention to upvote it by clicking on the ++ radio button, and continue by reading the replies. Sometimes I discover the node I originally upvoted is actually dead wrong -- in which case I may choose to change my vote to a downvote, or just decide not to vote on that node at all by navigating away from the page.

It doesn't happen often, but the flexibility would be very handy. Perhaps this should be user-configurable?

Alex / talexb / Toronto

"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds

I don't think it's really odd. We only have so many votes and sometimes will have to make tough choices on where to spend them, especailly when our remaining vote count is fairly low. It's nice to try and go back the next day and hit some of those nodes I couldn't but I may forget or something may come up that prevents me from hitting PM that day. I also think one-click voting makes accidental or knee-jerk voting more likely.

Have you used the "null vote"? It adds a radio button labeled +=0 which cancels your vote if you haven't submitted. Look at User Settings, under the miscellaneous section.

No ajaxy Web 2.0 feel, but it does allow you to change your vote.

Yes, I do use it.

I think that AJAX is the way to go for the voting buttons. I also hope we can reduce the cost of AJAX from 6K to something closer to 1K.

I'm not sure how other's vote, but I kind of mill about and think about things and sporadically vote, so this would speed up the experience for me, as well as reduce the over-all load to PM.

Hehe, I think I convinced PM that I'm a bot. When I used the last of my votes it says that I lost 27XP. I'm not to wrapped up in the XP but I do want to make sure that this code isn't getting seen as a bot. If some god could take a look and let me know I would appreciate it.

Thanks to a msg from ysth I discovered the bug that caused it to be detected as a bot. The node_id was getting messed up on pages where the voting booth is shown (which messed me up since i just recently added it to all pages....now if the voting both would go away after you vote!! ;) ) New version updated in the (greasemonkey plugin) sub-thread.


___________
Eric Hodges

I added the following patch in the appropriate place so that the ++ and -- don't run together:

            up_vote.innerHTML = "++";
            voting_both.appendChild(up_vote);
+           
+           var spacer = document.createElement("span");
+           spacer.innerHTML = " ";
+           voting_both.appendChild(spacer);
            
            var down_vote = document.createElement('a');
            down_vote.setAttribute("href",'javascript:void(0);');
[download]

Thanks for this patch, I've implemented it in the code here.


___________
Eric Hodges

Your latest version has a minor typo. Line 104 should be:

if (xpNodelet) {

instead of:

if (xpNodelet)