Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

Re^3: Perl 'grammar'

by gamache (Friar)
on Jan 09, 2008 at 16:26 UTC ( [id://661401] : note . print w/replies, xml ) Need Help??

in reply to Re^2: Perl 'grammar'
in thread Perl 'grammar'

Hell, why not sub format_name_for_AD {/(.+), (.)/ ? $2.$1 : undef}?

Replies are listed 'Best First'.
Re^4: Perl 'grammar'
by WoodyWeaver (Monk) on Jan 09, 2008 at 20:09 UTC
    Good point. You lose the uc bit, but its awfully tight.

    I think I was reacting more to the parameter unpacking. The sub is handed a compound, and the parameter is stored and then broken apart. I tend to think of that breaking as part of the unpacking process, so in essence get two params passed to the sub in a particular format, hence my "first" line produces those two variables.

    It all comes down to chasing errors, I suppose. I've gotten the habit of putting in a print (or warn) at subroutine entry with the parameters passed controlled by a debug variable. With the one-liner, you can't really do that. But then again, its so bloody simple, perhaps its not necessary.


      I tend to write my subroutines in three parts: first, a preamble where I throw the passed args into named variables; second, all the guts; and last, the return value. I find it helps with extensibility (but only barely).
        Me too. That must mean its a "best practice". :-)

        However, when unpacking the passed args into named variables, there is often some cleanup that needs to be done, such as assigning defaults for unpassed values, sanitizing, etc. I would tend to classify breaking "last, first" into "last", "first" as part of that 'throw into named variables' phase rather than the 'guts' phase, where you are making meaningful changes or performing analysis.

        I'm kinda weak about the last part, though. Sometimes I tend to return early, if I can determine what I'm going to send back from the subroutine. Screws up debugging, though. Use of your three part strategy means that one can put a print just before the final return, and gain insight into what the sub is really doing.