Well, what did you expect to hear? You already said what you wrote works, and didn't detail what failure meant to you. For example, your code obviously breaks if fed malformed data. But without knowing how you want to handle that, or even if you want to handle that, it is hard to discuss as a gotcha. The best advice would be to go grab a module that is fairly bulletproof with the grunt work, and keep your code as simple as possible.