http://qs1969.pair.com?node_id=702069


in reply to Re^2: Breaking Test::Differences
in thread Breaking Test::Differences

I didn't see the rudeness (no, I'm not who you replied to either). However, I will choose to be anonymous this time so I can minimize how much I have to deal with your immaturity at dealing with criticism.

"chipped" is a form of "broken". I don't know anything about what personal "fondness"es you might or might not have, but I'll try to make part of the original point clearer to you, This looks very much like shattering something because it was chipped.

And a patch that fixes comparison between numbers and numeric strings but breaks comparison of nesting levels sounds more like replacing some small fundamental cog with a side-effect of fixing a particular bug. It seems unlikely that it wouldn't be possible to more directly fix the bug and not introduce such a different bug.

If you feel the need to fundamentally change the whole heart of the module, you should probably start by making the "new world order" version an option (and an opt-in one at that).

Replies are listed 'Best First'.
Re^4: Breaking Test::Differences
by Anonymous Monk on Mar 23, 2010 at 09:22 UTC
    "chipped" is a form of "broken"

    Um, chipped is cosmetic damage (like a scratch on a car), broken is functional damage (broken axel, car inoperable).