Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: array reading problem

by linuxer (Curate)
on Nov 23, 2008 at 13:28 UTC ( [id://725417]=note: print w/replies, xml ) Need Help??


in reply to array reading problem

As rdfield already mentioned, your problem is in the assignment of open()'s result to your array @r.

When reading the file's content, remember that Perl doesn't remove the linebreaks automatically; that's up to you (use chomp() for that):

# ... @r = <DATFH>; chomp @r;
Instead of reading the complete file into an array (and into the memory) you can read linewise:
#!/usr/bin/perl use strict; use warnings; my $file = 'data.txt'; open my $datfh, '<', $file or die "$file: open(ro) failed: $!\n"; while ( my $line = <$datfh> ) { chomp $line; my @fields = split /\|/, $line; # work with your data fields } close $datfh or die "$file: close(ro) failed: $!\n";

update: paragraph tags and text added;
update2: typo fixed; thanks johngg

Replies are listed 'Best First'.
Re^2: array reading problem
by johngg (Canon) on Nov 23, 2008 at 18:08 UTC

    You have a small but significant typo in your code.

    while ( my $line <$datfh> ) {

    Should be

    while ( my $line = <$datfh> ) {

    Cheers,

    JohnGG

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://725417]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others contemplating the Monastery: (3)
As of 2024-04-18 01:57 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found