|
|
|
| Perl: the Markov chain saw | |
| PerlMonks |
Re^2: how to improve my scriptby afoken (Chancellor) |
| on Jun 15, 2009 at 17:59 UTC ( [id://771739]=note: print w/replies, xml ) | Need Help?? |
|
I'm missing taint mode and any kind of input validation. I see code written in Perl4 style (&log(...)), I see repeated (hidden) stat calls (-e $DOCROOT.$uri, then -d $DOCROOT.$uri, then -f $DOCROOT.$uri), I see open where stat is sufficient (# open $f to get its modification time). And I'm sure perlcritic would find a lot more than this. Alexander
-- Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
In Section
Seekers of Perl Wisdom
|
|
||||||||||||||||||||||