Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re (tilly) 1: Rabin Miller

by tilly (Archbishop)
on May 23, 2001 at 02:19 UTC ( [id://82416]=note: print w/replies, xml ) Need Help??


in reply to Rabin Miller

The following will speed up your calculation significantly:
# Doing $x ** $y can result in very large numbers, # But if what you want it ( $x ** $y ) % $m, then # you can pull the modulo into the products and keep # your numbers smaller. sub ModuloPwr { my($base,$pwr,$mod) = @_; return 1 if $pwr < 1; # I probably don't need the 0.1, but doesn't hurt. my $result = ModuloPwr($base, int(0.1 + $pwr/2), $mod); $result = ($result * $result) % $mod; if ($pwr%2) { $result = ( $result * $base ) % $mod; } return $result; }
However there appears to be a bug somewhere. It works fine for small primes, but for instance 97397 is reported not a prime, while it is. (I checked and double-checked. My change does not cause the issue.)

UPDATE
I am a moron. The bug is simple and obvious. Square then reduce modulo the prime works fine until the prime is large enough to go outside of native integer arithmetic. At that point things go haywire.

Replies are listed 'Best First'.
(tye)Re: Rabin Miller
by tye (Sage) on May 24, 2001 at 09:12 UTC

    But Perl's native integer range goes to about 2**56 so I think I introduced the bug when I handed Adam some code that uses &1 instead of %2. I suspect that if you fix that then you'll be able to handle past 8-digit primes.

            - tye (but my friends call me "Tye")

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://82416]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others studying the Monastery: (4)
As of 2024-04-19 04:26 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found