http://qs1969.pair.com?node_id=912035


in reply to Re^6: Find and replace MD5 hash from file
in thread Find and replace MD5 hash from file

I'm saying I have domain knowledge of the format, and that it never contains quotes. I also gave you a URL providing the makepasswd code as evidence. Have you read that?

  • Comment on Re^7: Find and replace MD5 hash from file

Replies are listed 'Best First'.
Re^8: Find and replace MD5 hash from file
by ikegami (Patriarch) on Jun 29, 2011 at 21:02 UTC

    I'm saying I have domain knowledge of the format, and that it never contains quotes.

    Thanks for the info.

    also gave you a URL providing the makepasswd code as evidence. Have you read that?

    Why would I? It wouldn't support or contradict anything you or I said.

      Your approach is absolutely fine in a code library providing the most generalisable possible solution for escaping arbitrary shell commands. There is nothing wrong with (the factual content of) your statements. All I am saying here is that in this specific case, where we have definitive evidence (even if you do not wish to examine that evidence) that quotes are never present, that a simpler approach is sufficient.

        All I am saying here is that in this specific case, where we have definitive evidence

        That's what you are saying *now*, and I don't have a problem with that. That's why I updated Re^2 in response to Re^7. Before Re^7, there was no mention of that.