Some comments on the code:
Digest::MD5::md5_hex is imported but not used. $location is initialised via user input but then not used. Line 61 could be simplified to: my $ext = $1; Lines 71 and 72 could be written as a single line: $filename =~ s{.*/(.*)$}{$1}; The next statements on lines 76 and 94 are redundant, as each occurs immediately before the loop iterates anyway. In addition, on line 94 the or clause does nothing. next can’t “fail”, and it doesn’t return a value. Lines 101 to 105 could be rewritten as a single line: print $error eq '' ? "No errors.\n" : "\nErrors: $error";
Hope that helps,
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
