You're loading Thread::Queue but not using it. You can much simplify your thread-creation logic with it:
sub Create {
my ( $sourcePath, $destinationPath ) = @_;
# ... create directories and stuff ...
my $tq = Thread::Queue->new();
for (1..5) {
push @arrThreads, threads->create(
sub {
while (defined(my $item = $q->dequeue())) {
DoSomethingWithItem($item, $sourcePath, $destinati
+onPath);
}
}
);
}
while (my ($k, $v) = each(%hashFileList)) {
$tq->enqueue( $v );
}
$tq->end();
foreach (@arrThreads) {
my $num = $_->join;
}
}
The major change here is that it's passing the files one item at a time to the threads. You're dividing them to n buckets and passing the whole bucket to the thread at creation time.
Apart from being nicer to look at, this one-at-a-time (supervisor-worker) approach should ensure that the threads will finish quicker since they're given equal amounts of work.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|