I've modified generate_md5sum to look like this ...
sub generate_md5sum
{
my ($fname) = @_;
my $sum = "file-not-readable ";
my $o_md5 = Digest::MD5->new;
my $fh = IO::File->new;
if ( open( $fh, "+<", $fname ) )
{
if ( flock( $fh, LOCK_EX | LOCK_NB ) )
{
binmode($fh);
$sum = $o_md5->addfile($fh)->hexdigest();
flock( $fh, LOCK_UN );
close $fh;
if ($b_dups)
{
$h_sums ||= {};
my $a_files = $h_sums->{$sum} ||= [];
push @$a_files, $fname;
}
}
}
return $sum;
}
Which allows the script to continue over locked or unreadable files.
Is this a good solution to this problem ?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|