comment on

I have this find script that only seems to work 1 out of 10 times. Most of the time it corrupts the files and messes up the data. It is supposed to change a word in a directory and ALL of its sub directories on an NT. Can someone advise what I am doing wrong here to make this work correctly??

use File::Find;

my @dirs = qw( . );

find ( \&change, @dirs );

sub change
{
    if ( -f && /\.html$/ )
    {
    my $file = $_;
    open(IN, $file) or die "CANT OPEN FILE!\n";
    
    while(<IN>)
    {
        $data .= $_; 
    }
    
    close IN;
    
    $buffer =~ s/OLDWORD/NEWWORD/gis;
    
    open(OPF,">$file") or die "NOT OPENING FILE FOR MOD, $!\n";
    print OPF "$data";
    close OPF;
    }
    }
[download]

In reply to File Find by oaklander

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Think about Loose Coupling
	PerlMonks