Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
A couple of pointers:

  • Instead of using the $_ variable for the name, I would suggest using $File::Find::name because that will more likely hold the correct filename you want.
  • Maybe I'm not understanding something but you're making your global changes to $buffer, but I only see it used once. Did you mean to make your change to $data?
  • Since you want to loop through many files and directories, you should perhaps change your dies to warns so the script continues, and you can hand modify the files.
  • Doing global changes will probably be faster if you slurp the whole file into memory all at once:
    { local $/ = undef; $buffer = <IN>; }
  • Regardless of whether or not the file contains OLDWORD, you're opening the file and rewriting it (which is where your corruption is probably coming from). You should only rewrite the file if you made any changes to it. The s/// regex returns the number of changes made, so as long as catch that change, you can test on the value later.
  • And according to the mantra here, always always
    use strict; use warnings;

Here's a quick untested rewrite I did to highlight the points I made.

use strict; use warnings; use File::Find; my @dirs = qw( . ); find ( { wanted => \&change, no_chdir => 1}, @dirs ); sub change { my $file = $File::Find::name; if ( -f $file && $file =~ /\.html$/ ) { open(IN, $file) or warn "CANT OPEN FILE!\n"; my $buffer; { local $/ = undef; $buffer = (<IN>); } close IN; my $changecount = ($buffer =~ s/OLDWORD/NEWWORD/gi); if ($changecount) { open(OPF,">$file") or warn "NOT OPENING FILE FOR MOD, $!\n +"; print OPF "$buffer"; close OPF; } } }

This could be optimized and shrunk I know, but I'll leave that to the gurus. I hope this helps.
Take care,

EDITED: Per a notice from Oaklander, the script would enter directories, but was not changing any of the files. A quick modification changed the call to File::Find from find ( \&change, @dirs ); to find ( { wanted => \&change, no_chdir => 1}, @dirs );.

I tested the code and it works as Oaklander needs.

In reply to Re: (Buzzcutbuddha - Some Corrections) - File Find by buzzcutbuddha
in thread File Find by oaklander

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?

What's my password?
Create A New User
Domain Nodelet?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others having an uproarious good time at the Monastery: (5)
As of 2023-12-11 00:03 GMT
Find Nodes?
    Voting Booth?
    What's your preferred 'use VERSION' for new CPAN modules in 2023?

    Results (41 votes). Check out past polls.