comment on

That is some ugly code. It generates incorrect HTML (it has so many errors, that you should read "HTML for dummies" again), not that my fix will go through a validator...
The code is completly unmaintainable and gives the impression that you have absolutely no idea of what you are doing.

#!c:\perl\bin\perl.exe -w

use strict;

my @imgArray = (
                {
                 file => "./pics/blink.gif",
                 h => 320,
                 w => 240,
                 title => "Blink 128 (1)",
                },
                {
                 file => "./pics/sum41.gif",
                 h => 316,
                 w => 500,
                 title => "Sum 41",
                },
                #and so on
                ...
               );

#dont use srand, unless you want a PREDICTABLE series of numbers every
+ time!
my $num = rand(@imgArray);
my $img = $imgArray[$num];

print "Content-type: text/html\n\n";

print <<HTML;
<html>
<head>
  <title></title>
</head>
<body bgcolor=lightgrey>
Index: $num <br>Image: $$img{file}
<br>
<br>
<center>Random imaging with Perl.....</center>
<br>
<br>
<center>
<img src="$$img{file}" border=1 height="$$img{h}" width="$$img{w}">
<br>
<br>
<font>$$img{title}</font>
</center>
</body>
</html>
HTML
[download]

T I M T O W T D I

In reply to Re: Random Imaging by Cine
in thread Random Imaging by appex32

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


No such thing as a small change
	PerlMonks