Some helpful indentation would point out troubles with your code.
Nested magical while loops will walk on each other's $_. I don't think that is hurting you here, but it will someday.
You have a logic bug, your code says,
while ( lines_to_read() ) {
if ( the_line_is_the_right_header()) {
if ( the_line_also_has_impressions) {
# impression things
}
}
}
No line satisfies both conditions. You need to last out of the inner loop if the header is wrong. If the header is right keep saying next until you find "Impressions:" or run out of lines.
Your impression handling code treats a string with leading spaces (from split /:/) as a number. That will always evaluate to zero. [ysth++ is correct. I still think:] split /:\s*/ will work better.
Update: Here is the whole loop in pseudocode with last and next applied to fix the logic,
while (files_to_read()) {
next unless the_line_is_the_right_header();
while ( lines_to_read() ) {
next unless the_line_has_impressions();
# impression things
last; # no need to look further in this file
}
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|