Could could make this code a
lot cleaner. Notably, that mess of splits and data assignments at the top, using
`ls` when you should be using
readdir, and scoping of variables.
Here's what i came up with after five minutes:
sub PRINT_INFO {
my ($netid, $sitename, $sector) = @_;
my $DAILY_HEAD = "Date Total";
$,="\t"; #Output Field Separator
my $report_type = 'Daily Totals';
my $MARKET = 'PHL';
my $DAILY_PATH = "/data1/$MARKET/reports";
my $BUSY_PATH = "/data1/$MARKET/bhreports";
my $PKD_PATH = "/data1/$MARKET/pkdreports";
my $MISC_PATH = "/data1/$MARKET/miscreports";
my $MDG_PATH = "/data1/$MARKET/mdgreports";
my $cellname = "$sitename Sector $sector";
my $search_string = "\Q$netid";
print "$cellname\n";
opendir DIR, $DAILYPATH;
my @all_readable_files = grep { ($_ ne '.') && ($_ ne '..') && ($_
+ !~ /\.Z//) } readdir DIR;
closedir DIR;
print "$DAILY_HEAD\n";
my $file;
foreach $file (@all_readable_files) {
my $date = substr ($file, 0 , (index $file, '_'));
open(FILE, "$DAILY_PATH/$file");
@DATA=<FILE>;
@result = grep { (index $_, $search_string) > -1 } @DATA;
for ( $i = 0; $i <= $#results; $i++ ) {
my $info = (split(' ', $result[$i]))[7];
print $date , $info . "\n";
}
close FILE;
}
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.