comment on

But not nearly as fun, nor nearly as educational. Actually not using any other module was the point for me creating it.

Fine, then post it here with "I know there are ways to do this with a few modules, but one of my design goals was to not use modules". Otherwise, I waste a lot of time trying to figure out why you didn't use modules, which is a silly goal for production code.

I would appreciate any comments on code quality, if you have any.

Well, let's just start with the inefficiencies and errors of these two lines:

        my @files = map { "$dir/$_" } grep { !/^\.{1,2}$/ && -f "$dir/
+$_" } @tmp;
        my @dirs  = map { "$dir/$_" } grep { !/^\.{1,2}$/ && -d "$dir/
+$_" } @tmp;
[download]

Let's see. Twice as many stats as you need (because you can get whether it's a file or a dir with one stat). Breaks on files named "..\n" (because you'll reject that with your regex match needlessly). So there's a bug and a misfeature, just in those two lines.

I personally do not see anything wrong with reinventing the wheel as long as you know it's not necessary.

I do. You've posted this code here. Some crazy fool is going to cargo-cult your code without paying attention to your design goals or the following commentary. And that puts more bad Perl code in the world, not good code. {sigh}

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

In reply to Re^3: Find images regardless of filetype extension. by merlyn
in thread Find images regardless of filetype extension. by zzspectrez

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


"be consistent"
	PerlMonks