I have a set of strings returned from a function depicting Active Directory user accounts. The string is in the form of:
Win32_Account.Domain="ADDomain",Name="aduser1"
Win32_Account.Domain="ADDomain",Name="aduser2"
Win32_Account.Domain="ADDomain",Name="aduser3"
Win32_Account.Domain="ADDomain",Name="aduser4"
I would like to change the format to read:
ADDomain\aduser1
ADDomain\aduser2
ADDomain\aduser3
ADDomain\aduser4
So they can easily be understood on a report.
I am currently using the following code to perform this task.
#!/usr/bin/perl -w
use strict;
use warnings;
my $string = q/ Win32_Account.Domain="ADDomain",Name="aduser1"/;
my ( $domain, $uname ) = split( ",", $string );
$domain =~ s/\"//ig;
$domain =~ s/Win32_Account.Domain=//ig;
$uname =~ s/\"//ig;
$uname =~ s/Name=//ig;
#concat the parts or replace with Account Deleted if SID not found
my $user = ( $uname eq "" ? "Account Deleted" : $domain . "\\" . $unam
+e );
print $user;
Although the code works, is there a more efficient way to do the work. Any advice would be welcomed.
Thank you,
Greg W.
Update:
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.