As a beginner, I made all of these mistakes and then some. Thank you chromatic for this excelent node, and dominus for the Red Flag papers. While forcing myself to rewrite a script to have them all use strict I came up with the following solutions which may be of benefit to others like me (for most of you this is way too trivial, but this is the voice of a beginner).
To access a number of files in a loop construct, this was my initial attempt:
for ($results = 2; $results <34; $results++) {
my $file="current$results.res";
open (TALLYRESULTS, ">$file") or die ("cant open results f
+ile");
....
}
A common mistake, apparently, which turned out to be easy to avoid:
for ($results = 2; $results <34; $results++) {
my $file="current".$presence.".res";
....
}
Another (double!) 'Red Flag' situation was this:
@tree1=@samples[0..2];
... (another 10 of those)
@tree12=@samples[33..35];
for ($z = 1; $z <= 12; $z++) {
$arrayname="tree$z";
foreach $patch(@$arrayname) {
... do something
}
and solving it taught me a thing or two about hashes:
my %trees = (1 => "@samples[0..2]",
... (another 10 of these)
12 => "@samples[33..35]",
);
while ((my $tree, my $samples) = each (%trees) ){
my @patches = split (/ */, $samples);
foreach $patch(@patches) {
... do something
}
My script now runs under strict, and I'm proud of it ;-)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.