You shouldn't have the %animal_sounds as a global variable in the main namespace (main:: or ::), but maybe have it as a global variable in the Animal:: namespace. You don't need the BEGIN blocks around your animal registration section, and you also don't break stricture.
Personally, I would use any of the Pluggable modules, like Module::Pluggable, especially when you want new plugins to become automatically discovered when they are available:
package Animal;
use Carp qw(croak);
use Module::Pluggable
require => 1,
search_path => 'Animal',
sub_name => known_animals;
# use Memoize;
# memoize('known_animals');
my @known_animals = __PACKAGE__->known_animals;
my %animal_sounds;
for my $animal (@known_animals) {
for my $sound ($animal->sounds) {
croak "Ambigous sound '$sound' ($animal / $animal_sounds{$soun
+d})"
if exists $animal_sounds{$sound};
$animal_sounds{$sound} = $animal;
};
};
# and in a separate file Animal/Dog.pm:
package Animal::Dog;
sub sounds { 'woof' };
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|