I have a difficult time seeing this as "good" code:
while (<STDIN>) {
chomp;
if ($_ =~ /hello/) {
&style1();
}
else {
&style2();
exit;
}
}
sub style1() {
print "hello\n";
}
sub style2()
{
print "bye\n";
}
There's inconsistent brace styling, the useless use of & on
subroutine calls, useless prototypes, and a useless use of $_ =~.
I'm not sure if explictly using STDIN is helpful either; it
depends on the intent of this program. I hate to miss out on magic
ARGV behavior. I'm also not sure that chomp has
any value in the code snippet.
How about:
while (<STDIN>) {
unless (/hello/) {
style2();
exit;
}
style1();
}
sub style1 {
print "hello\n";
}
sub style2 {
print "bye\n";
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|