Have you checked the results of your code for Fisher's Exact Test? I don't think it produces correct results.
Here's a utility that produces results identical to those I calculate:
This expression at the beginning of your code seems odd:
$test = $a*($a+$b+$c+$d ) - ($a+$b)*($a+$c);
It simplifies to:
$test = $a*$d - $b*$c;
I don't follow why you have this:
return 1 if $test < 0 and $ts;
For example, if a = 1, b = 50, c = 10 and d = 5, P(one-sided) = P(two-sided) = 1.4386e-07, not 1.
Nevertheless, thanks for the tip about calculating factorials only once. Let me know if I've misunderstood something.
Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
Want more info? How to link
or How to display code and escape characters
are good places to start.