I have a simple script which should list all the files in a given directory, then read them one by one, checking for dos format. That list is then printed out. My problem is, after the grep, the @files array ends up containing lines from the files I'm reading, when it originally contains the paths to the files.

I'm guessing this is because (inside the grep )$_ is an alais to the array value, so the file read is automagically smashing this, and making it back into my array.

That would be a pretty bad gotcha, and one I'd be surprised I'd not run across until now. If that's is indeed the case, could someone please suggest an alternative/ways to avoid this?

Anywho, here's the distilled example...

#!/usr/bin/perl
use strict;
use File::Find;

my $directory = "/tmp/rja/find_test";

my @files = ();
find(sub { $File::Find::name =~ m/${directory}(.*)$/; push @files, $1}
+,  $directory);
@files = grep { is_dos_format("$directory/$_") } @files;

foreach my $file (@files) {
    print "FAILED FILE - $file\n";
}



#==============================================================
sub is_dos_format {
    my $file_path = shift;
    
    open RJA, $file_path or die("Couldn't open file for reading ($file
+_path): $!");
    while (<RJA>) {
        if ($_ =~ m/\r\n/) {
            return 1;
        }
    }
    
    return;
}
[download]