Here is some advice
- Use File::Spec->catfile for building the directory locations and pathnames
- Dont use constant open form, see open ( my $fh, $rw, $perm ) format
- I think reading in the whole file is probably better for whatever you want, on a modern system
- Don't grep for a file_path if the call requires it to be there
try something like:
#!/usr/bin/perl -l
use strict;
use File::Find;
use File::Spec;
use constant DIRECTORY => '/tmp/rja/find_test';
my @files;
find( \&findsub, __PACKAGE__->DIRECTORY );
@files = grep is_dos_format($_), @files;
foreach my $file (@files) {
print "FAILED FILE - $file";
}
sub findsub {
push @files, $File::Find::name;
}
sub is_dos_format {
my $abs_path = shift;
open ( my $fh, '<', $abs_path )
or die "open $abs_path: $!"
;
if ( grep m/\r\n/s, <$fh> ) {
return 1;
}
return undef;
}
Evan Carroll www.EvanCarroll.com
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|