Almost.
- You forgot to convert the text to a regexp pattern.
- You only replace the first instance.
- And since I'm already changing the line, I'll remove the useless use of map.
$text =~ s/\Q$_\E/$fixers{$_}/g
for keys %fixers;
It could still be improved if it's going to be done repeatedly.
my ($re) = map qr/$_/,
join '|',
map quotemeta,
keys %fixers;
while (...) {
...
$text =~ s/$re/$fixers{$_}/g
for keys %fixers;
...
}
Or even better for pre-5.10
use List::Regexp qw( );
my $re = List::Regexp->new()->list2re( keys %fixers );
while (...) {
...
$text =~ s/$re/$fixers{$_}/g
for keys %fixers;
...
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|