Assuming you're not hanging on to old versions of Perl, I'd write it as:
given ($_) {
when (/filename\s*=\s*(\S+)/) {$file = basename($1)}
when (/go/ && exists $files{$file}) {
push @PLACE, @batch;
delete $files{$file}
}
@batch = ();
If it's in a for loop, and $_ is your loop variant, you can even omit the given.
Thing is, I think I understand what is happening here but not why: essentially, the call to basename() is not finding a good value in $1, which should have been returned from the match by the (\S+).
But you're not matching. qr// creates a pattern, it does not perform a match. qr/filename\s*=\s*(\S+)/ is always true. If you want to match, use m// instead.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|