No, it should look exactly like the first statement. The ternary operator is very good if you use its value, but if you use it in void context it's just a kludge for an if statement. So
# bad: ternary in void context:
exists($checked->{Group}{$GroupDN}) ? ($rc_OK=1) : ($rc_OK=check_group
+($GroupDN,0));
# good: 'if' in void context:
if (exists($checked->{Group}{$GroupDN})) {
$rc_OK = 1
} else {
$rc_OK=check_group($GroupDN,0)
}
# also good: ternary in scalar context:
$rc_OK = exists($checked->{Group}{$GroupDN}) ? 1 : check_group($Group
+DN,0)
So you have two good, idiomatic ways to express something, and complain that the third is a PITA?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|