Why set the length of the array only to change it immediately? I also hate the needless use of global vars.
my @path = '.';
while (<DATA>) {
chomp;
my ($prefix, $node) = /^((?:\| )*[|`]-- )(.+)/
or next;
$#path = length($prefix)/2 - 1;
$path[-1] = $node;
print $prefix, join("/" => @path), "\n";
}
Alternative, we could use
splice.
my @path = '.';
while (<DATA>) {
chomp;
my ($prefix, $node) = /^((?:\| )*[|`]-- )(.+)/
or next;
splice @path, length($prefix)/2-1, 0+@path, $node;
print $prefix, join("/" => @path), "\n";
}
It avoids the addition of magic to @path, and it combines two operations. The latter usually makes something more readable, but it's unfortunately not the case here.
Speaking of readability, that regex is rather hard to read. I had something like that initially, but I switched to split because it was much more straightforward.
my @path = '.';
while (<DATA>) {
chomp;
my ($prefix, $node) = split(/(?<=-- )/, $_, 2)
or next;
$#path = length($prefix)/2 - 1;
$path[-1] = $node;
print $prefix, join("/" => @path), "\n";
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.