Re^3: Prepending to a file

in reply to Re: Re: Prepending to a file
in thread Prepending to a file

Instead of

  or die "Could not open file ", FILE, ": $!";
[download]

don't you want

  or die "Could not open file ", $file, ": $!";
[download]

Comment on Re^3: Prepending to a file Select or Download Code

Replies are listed 'Best First'.
Re^4: Prepending to a file by afoken (Chancellor) on Oct 01, 2016 at 06:49 UTC
`or die "Could not open file ", $file, ": $!";` Looks good. It seems you found a bug. Because filenames may contain spaces and other "invisible" characters, especially when the code generating the filename has a bug (e.g missing chomp), you may want to quote it in the error message. And you could use string interpolation for the filename. So: `or die "Could not open file '$file': $!";` Alexander -- Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^4: Prepending to a file
by afoken (Chancellor) on Oct 01, 2016 at 06:49 UTC

or die "Could not open file ", $file, ": $!";

Looks good. It seems you found a bug.

Because filenames may contain spaces and other "invisible" characters, especially when the code generating the filename has a bug (e.g missing chomp), you may want to quote it in the error message. And you could use string interpolation for the filename. So:

or die "Could not open file '$file': $!";

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom