in reply to Pulling by regex II
- Tight deadline
- Performance
- Working code
Now, a few of these don't match. Even more don't add up when you add priorities that you *should* have, notably "secure".
So, lets detail some of the issues we have with the code thus far:
- Reading in entire log file (into ram no less) every time the script is run
- No use of taint mode
- No use of warnings
- Bad choice of time comparison algorithm
- Iffy regexen
Under these circumstances, without access to help, you should be getting your priorities in order. While it depends on your particular position, the following is a good start:
- Working code
- Working, secure code
- Working, secure code by deadline
- Working, secure, maintainable code by deadline
- Working, secure, maintainable code that performs well, by deadline
What does this mean? Well, the first thing it means is that if a well known, already-debugged module is around that can do any part of the problem you're trying to solve, use it. Performance is waaay down on the list, just use it. If it really turns out too slow in use, *then* you worry about it.
The second thing it means is a quick investigation of language features that can help you out with debugging and security. Taint mode, Strict and Warnings should all be on, and you shouldn't move an inch until your code is working with all of them.
Now, if you had done this, most of the code above, that isn't working, wouldn't even exist. You'd have something a fraction of the size, that worked fine. Maybe it'd be a bit slow, maybe not, but if it was, you'd be posting to perlmonks saying "Hey, here's my working code, how can I make it go a bit faster", and then people like Abigail-II would have been able to tell you how exactly a database would aid your cause, even when the logs are in text file format. But we're not there yet.
#!/usr/bin/perl -t use strict; use warnings; use Date::Manip; use CGI qw/:standard/; # Make sure neither we, nor any of our submodules compromise security # by calling unpathed programs. $ENV{PATH} = "/bin:/usr/bin"; $ENV{IFS}=""; # Use CGI to print our headers print header; my %referers = (); # Retrieve and security-check parameters my $hour = param('hour'); my $minute = param('minute'); if ($hour !~ /^\d\d?$/) { die('Invalid hour'); } if ($minute !~ /^\d\d?$/) { die('Invalid minute'); } # Get date object for our check point my $check_date = ParseDate("${hour}hours ${minute}minutes ago"); # File handling, one line at a time open(FH,"file") || die('Could not open log file'); while (my $line = <FH>) { next if ($line !~ /^\S+ \S \S (\S+) \S+ "[^"]+" \d+ \d+ "([^"]+)"/ +); my $line_date = ParseDate($1); # Check to see if the line date is in the range we're after next unless Date_Cmp($line_date, $check_date)>0; # If the referer is new, we set to 1 entry, otherwise increment (i +ncrementing undef doesn't work well) if (!$referers{$2}) { $referers{$2}=1; } else { $referers{$2}++; } } close(FH); my $row = 0; # Sort our referers by the number of hits for (sort {$referers{$b} <=> $referers{$a}} keys %referers) { # break out after the tenth one last if $row++==10; print "$_: ".$referers{$_}."\n"; }
This is by no means perfect, I didn't have enough log examples to work from to be sure the regex will work well, but it contains all the properties of a good first effort. All the necessary warnings and taints turned on, the relevant modules used (there is, I think, an apache log parsing module too, but I wasn't sure you were using apache), all user input is verified and no more code than strictly necessary is used.
The end result...no weird month name/number conversions, about 30 seconds of debugging, and a much better product. I highly recommend, prior to your next project, sitting down and listing your priorities as above, it will help focus you on what really matters first, and what can be tweaked second.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re: Pulling by regex II
by PhiRatE (Monk) on Dec 13, 2002 at 11:21 UTC | |
|
Re: Re: Pulling by regex II
by mkent (Acolyte) on Dec 14, 2002 at 23:07 UTC | |
by PhiRatE (Monk) on Dec 14, 2002 at 23:40 UTC | |
by mkent (Acolyte) on Dec 15, 2002 at 20:54 UTC | |
by PhiRatE (Monk) on Dec 16, 2002 at 10:54 UTC | |
by mkent (Acolyte) on Dec 19, 2002 at 16:51 UTC | |
by DapperDan (Pilgrim) on Dec 14, 2002 at 23:52 UTC |