http://qs1969.pair.com?node_id=1149830


in reply to Best practices for passing in function arguments?

my $array_ref = {}; push(@$array_ref, {});
The code above, which is part of your second example, gives an error because $array_ref = {} initializes your $array_ref to a hash ref which is not compatible as the first argument of push. It may be sort of symptomatic of your programming difficulties in that initializing $array_ref to a hash ref is confusing and just looks like code that is headed off in the wrong direction. I think your examples add more complication than needed and, for me, trying to simplify gives a result like:
use strict; use warnings; sub foo { my %hash = (); .... %hash = .... # key/values populated by some API bar(\%hash); } sub bar { my $hash_ref = shift; my @arr_of_href = $hash_ref; foreach my $i (.....) { .... %some_hash initialized here for each iteration of the for + loop push (@arr_of_href, \%some_hash); } zzz(\@arr_of_href); # zzz() will do something with this array }
Ron

Replies are listed 'Best First'.
Re^2: Best practices for passing in function arguments?
by andrewkl (Novice) on Dec 09, 2015 at 21:32 UTC
    sorry about the incorrect usage; i've corrected the code snippet.