warn "..." unless $type;<code>
<p>which are both more efficient and clearer.

<p>However, you then go on to use $type as a hash key in
<p><code>       $by_type{$from}{$type} += $tmp_c;