sub get_suite_vars{ my %suite; my ($job_vars, $job); my @jobs = ('MOR2305.xml', 'MOP4312.xml', 'IN543.xml'); foreach $job ($jobs){ $job_vars = make_var_hash($job); #UPDATE for anyone interested the error was here #In my original code I had foreach $key($job_vars){ #SORRY foreach $key (keys($job_vars)){ print "$key = $$job_vars{$key}[0] & $$job_vars{$key}[1]\n"; } $suite{$job}=$job_vars; } return \$suite; }