my $query; if ($action eq 'Problem Submit') $query = "INSERT INTO Ticket_Data ("; for $key ( keys %ORA_MAPPING ) { my $value = $ORA_MAPPING{$key}; next if $key eq "Data_id"; $query.=" $value, "; # or did you really mean $key here? }