in reply to Re: Problem in creating process
in thread Problem in creating process

Here is the code for that function. These functions open the file and build some hashes to upload into DB. Always SMSBcastCDR functions completes it work first(Due to less data). To upload the values into DB i am waiting for both the process complete their work. 

sub SMSBcastCDR 
{
    my @array = @_; 
    foreach my $cdr_file (@array)
    {
        chomp $cdr_file;
        print "file name=$cdr_file\n";
        open (FPO,"$cdr_file") or die "Could not open $cdr_file\n";
        while (my $line = <FPO>)
        {
            #Tue Jun 09 2009 23:00:07.225|user2|KAuser2|2222|919846231
+229|1520095992858641|TextSMS|2009-Jun-09 23:00:07.225||150|Submitted|
+|231229|0|Success|
            chomp ($line);
            my ($cdr_gen_time,$system_id,$msg_submission_time,$msg_del
+ivery_time,$record_type,$last_failure_reason) = (split /\|/,$line)[0,
+1,7,8,10,14];
            #2009-Jun-09 23:00:07.225
            my ($year,$mon_txt,$day,$hr) = (split /[-:\s]+/, $msg_subm
+ission_time)[0,1,2,3];
            my $statsdate = "$hr:$year-$month_name{$mon_txt}-$day";
            if ($record_type eq "Flood_Control_Check")
            {
                #Mon Jul 19 2010 15:36:15.682
                $msg_submission_time=$cdr_gen_time;
                my ($mon_txt, $day, $year, $hr) =  (split /[-:\s]+/,$c
+dr_gen_time)[1,2,3,4];
                $statsdate = "$hr:$year-$month_name{$mon_txt}-$day";
            }
            #print "$record_type:$statsdate\n";
            if ($msg_submission_time ne "")
            {
                push (@date_list,$statsdate) unless $seen{$statsdate}+
++;
            }
            else
            {
                my ($txtdate, $time) = split(/\ /,$msg_delivery_time);
                my ($year,$mon_txt,$day) = split(/\-/,$txtdate);
                my $mon = $month_name{$mon_txt};
                my ($hr,$min,$sec) = split(/\:/,$time);
                $statsdate = "$hr:$year-$mon-$day";
                if ($msg_delivery_time ne "")
                {
                    push (@date_list,$statsdate) unless $seen{$statsda
+te}++;
                }
            }
            $hour_info{$statsdate}{$hr}=0;
            $system_id_info{$statsdate}{$system_id} = 0;
            if ($record_type eq "Submitted")
            {
                $sub_data{$statsdate}{$system_id} ++;
                $sub_data{$statsdate}{'all'} ++;
            }
            elsif($record_type eq "DND_Check" || $record_type eq "Filt
+er_Check" || $record_type eq "Special_Character_Check" || $record_typ
+e eq "Message_Length_Check" || $record_type eq "Invalid_Message" || $
+record_type eq "NID_Check" || $record_type eq "Mobile_No_Check" || $r
+ecord_type eq "Flood_Control_Check")
            {
                push (@rej_error_list,$last_failure_reason) unless $re
+j_seen{$last_failure_reason}++;
                $rej_data{$statsdate}{$system_id} ++;
                $rej_data{$statsdate}{'all'} ++;
                $bcast_errcnt{$statsdate}{$system_id}{$last_failure_re
+ason}++;
                $bcast_errcnt{$statsdate}{'all'}{$last_failure_reason}
+++;
            }
            elsif($record_type eq "SubmitResp")
            {
                if ($last_failure_reason ne "Success")
                {
                    push (@rej_error_list,$last_failure_reason) unless
+ $rej_seen{$last_failure_reason}++;
                    $smsc_rej_data{$statsdate}{$system_id} ++;
                    $smsc_rej_data{$statsdate}{'all'} ++;
                    $bcast_errcnt{$statsdate}{$system_id}{$last_failur
+e_reason}++;
                    $bcast_errcnt{$statsdate}{'all'}{$last_failure_rea
+son}++;
                }
            }
        }
        close (FP);
        `mv $cdr_file $bcastdir`;
    }
}

[download]
sub SMSCDR 
{
    my @array = @_;
    foreach my $cdr_file (@array)
    {
        chomp $cdr_file;
        print "File:::::: $cdr_file",$/;
        open (FPS,"$cdr_file") or die "Could not open $cdr_file\n";

        while (my $line = <FPS>)
        {
            chomp ($line);
            my (
                    $msg_submission_time,#5
                    $status,#8
                    $record_type,#10
                    $last_failure_reason,#12
                    $orig_interface,#13
                    $dcs,#15
                    $segment_number ,#23
                    $system_id ,#56
               )= (split /\|/,$line) [4,7,9,11,12,14,22,55];
#Wed Jun 10 16:58:58 2009
            my ($mon_txt,$day,$hr,$year) =  (split /[-:\s]+/,$msg_subm
+ission_time)[1,2,3,6];
            my $statsdate = "$hr:$year-$month_name{$mon_txt}-$day";
#print "statsdate :$statsdate\n";
            push (@date_list,$statsdate) unless $seen{$statsdate}++;
            $hour_info{$statsdate}{$hr}=0;
            if (($orig_interface eq "SMPP") && ($record_type eq "Submi
+t"))
            {
                my ($segment_no,$x) = split (/\//,$segment_number);
                if ((lc($segment_no) eq "none") || ($dcs eq "8") || ($
+dcs eq "16") || (($dcs eq "ASCII") && ($segment_no eq "1")))
                {
                    $system_id_info{$statsdate}{$system_id}=0;
                    if($sms_sub_data{$statsdate}{$system_id} eq "")
                    {
                        $sms_sub_data{$statsdate}{$system_id} = 0;
                        $del_data{$statsdate}{$system_id} = 0;
                        $undel_data{$statsdate}{$system_id} = 0;
                        $exp_data{$statsdate}{$system_id} = 0;
                    }
                    $sms_sub_data{$statsdate}{$system_id} ++;
                    $sms_sub_data{$statsdate}{'all'} ++;
                    if ($status eq "Delivered")
                    {
                        $del_data{$statsdate}{$system_id} ++;
                        $del_data{$statsdate}{'all'} ++;
                        if ($last_failure_reason eq "SMSC_no_error")
                        {
                            $last_failure_reason = "First_Attempt_Deli
+vered";
                        }
                        else
                        {
                            $last_failure_reason = "Delivered_After_Re
+try";
                        }
                        $del_errcnt{$statsdate}{$system_id}{$last_fail
+ure_reason} ++;
                        $del_errcnt{$statsdate}{'all'}{$last_failure_r
+eason} ++;
                    }
                    elsif ($status eq "Expired")
                    {
                        $exp_data{$statsdate}{$system_id} ++;
                        $exp_data{$statsdate}{'all'} ++;
                        push (@exp_rej_error_list,$last_failure_reason
+) unless $exp_seen{$last_failure_reason}++;
                        $exp_errcnt{$statsdate}{$system_id}{$last_fail
+ure_reason} ++;
                        $exp_errcnt{$statsdate}{'all'}{$last_failure_r
+eason} ++;
                    }
                    else
                    {
                        $undel_data{$statsdate}{$system_id} ++;
                        $undel_data{$statsdate}{'all'} ++;
                        push (@undel_rej_error_list,$last_failure_reas
+on) unless $undel_seen{$last_failure_reason}++;
                        $undel_errcnt{$statsdate}{$system_id}{$last_fa
+ilure_reason} ++;
                        $undel_errcnt{$statsdate}{'all'}{$last_failure
+_reason} ++;
                    }

                }
            }
        }
        close (FP);
        `mv $cdr_file $smscdr_archive_directory`;
    }
}

[download]

Replies are listed 'Best First'.
Re^3: Problem in creating process
by BrowserUk (Patriarch) on Nov 23, 2015 at 11:50 UTC

    Where do these hashes used in these subroutines come from? %hour_info, %system_id_info, %sub_data, %rej_data, %bcast_errcnt, %smsc_rej_data, %sms_sub_data, %del_data, %undel_data, %del_errcnt, %xp_data, %exp_errcnt etc.

    I've probably missed a few and there are arrays as well.

    Are they globals? What do you do with the data you've accumulated in them? Is the data accumulated and reset on a per file basis? Or accumulated across all the files of the given type?

    With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
    Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
    "Science is about questioning the status quo. Questioning authority". I knew I was on the right track :)
    In the absence of evidence, opinion is indistinguishable from prejudice.
[reply]
[d/l]

      Those are global. In that "some" hashes are used to upload to DB & all the hashes used to write an xlsx sheet

[reply]
        Those are global. In that "some" hashes are used to upload to DB & all the hashes used to write an xlsx sheet

        So, presumably that post file-processing code runs where I've added comments below? 

        foreach my $linkarray (1 .. 2) 
{
    $pm->start and next LINKS; # do the fork
    
    if ($first == 1)
    {
        my @cdr_list1 = `ls $cdr_directory/SMSBcastCDR_*_$bcat_cdrdate
+\_*.log`;
        print "cdrs_file1 = @cdr_list1\n";
        SMSBcastCDR(@cdr_list1);
        $first++;
                ## Update DB and produce xlsx sheet from global hashes
+ and arrays here????
    }
    if ($first == 2)
    {
                my @smsc_cdr_list=`ls $smscdr_directory/SMSCDR_P*_$cdr
+date*.log`;
        SMSCDR(@smsc_cdr_list);
                ## Update DB and produce xlsx sheet from global hashes
+ and arrays here????
    }
    $pm->finish; # do the exit in the child process
}
$pm->wait_all_children;

        [download]

        I have another suggestion: Instead of waiting for all your files to finish being written at midnight before starting your processing; run your process(es) to constantly monitor their respective directories throughout the day and process the files as they arrive.

        That way, when the final file arrives there'll only be a tiny amount of processing left to do and your stats will be available very shortly after.

        With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
        Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
        "Science is about questioning the status quo. Questioning authority". I knew I was on the right track :)
        In the absence of evidence, opinion is indistinguishable from prejudice.
[reply]
[d/l]

In Section Seekers of Perl Wisdom