Re^3: passing @ to sub and getting back hash

How would that be "better"?

$ perl -MData::Dumper -le'
my @dc = ( "xxxx-123:xxxxxxABC,z", "xxxx-:xxxxxx,z", "xxxx-456:xxxxxx,
+z", "xxxx-XXX:xxxxxxDEF,z", "xxxx-789:xxxxxxGHI,z" );
my %hash1 = map /^xxxx-(\d+):xxxxxx([^,]+),.+$/, @dc;
my %hash2 = map { /^xxxx-(\d+):xxxxxx([^,]+),.+$/ ? ($1 => $2) : () } 
+@dc;
print Dumper \%hash1, \%hash2;
'
$VAR1 = {
          '123' => 'ABC',
          '789' => 'GHI'
        };
$VAR2 = {
          '123' => 'ABC',
          '789' => 'GHI'
        };
[download]

Comment on Re^3: passing @ to sub and getting back hash Download Code

Replies are listed 'Best First'.
Re^4: passing @ to sub and getting back hash by NetWallah (Canon) on Jan 01, 2008 at 04:12 UTC
Grandfather's statement is better because it gracefully(and explicitly) handles the case where the regex does not match. "As you get older three things happen. The first is your memory goes, and I can't remember the other two... " - Sir Norman Wisdom	[reply]
Re^5: passing @ to sub and getting back hash by GrandFather (Saint) on Jan 01, 2008 at 05:03 UTC
My New Year's resolution is to remember (from Regexp Quote Like Operators): If the /g option is not used, m// in list context returns a list consisting of the subexpressions matched by the parentheses in the pattern, i.e., ($1, $2, $3...). (Note that here $1 etc. are also set, and that this differs from Perl 4's behavior.) When there are no parentheses in the pattern, the return value is the list (1) for success. With or without parentheses, an empty list is returned upon failure. My version simply does explicitly what jwkrahn's code does implicitly. So 'better' is a function of remembering the match operator's behavior in list context, which for some reason (probably to do with skull thickness) I seem to have trouble doing. Perl is environmentally friendly - it saves trees	[reply]