Re^5: Regex help/ Lua parse

Compare your original version (with all regexes reduced to regex to alleviate noise)

sub buildTables {
    while (<>) { 
        if (/regex/)
        { $theme_table{$1} = $2 }
        if (/regex/)
        { $taglist_table{$1} = $2 }
        if (/regex/)
        { $menu_table{$1} = $2 }
        }
        #print Dumper \%theme_table;
        #print Dumper \%taglist_table;
        #print Dumper \%menu_table;
}
[download]

with this alternative version

sub buildTables {
    while (<>) {
        if (/regex/) {
            $theme_table{$1} = $2
        }   
        if (/regex/) {
            $taglist_table{$1} = $2
        }   
        if (/regex/) {
            $menu_table{$1} = $2
        }   
    }
}
[download]

Which looks clearer to you? Is the closing brace of the while loop more or less obvious to you now? How about providing me with some examples of code that looks like yours.

-- Ken

Comment on Re^5: Regex help/ Lua parse Select or Download Code

Replies are listed 'Best First'.
Re^6: Regex help/ Lua parse by marquezc329 (Scribe) on Oct 27, 2012 at 18:52 UTC
Aaah. I see. It seems much more obvious to me with the reduced regexes. I've never used such extensive regexes and I think I may have been letting myself get overwhelmed and distracted by the length and complexity of these statements in comparison to the shorter more basic code I've been learning with. So in essence, `if (x = y) { print x; }` [download] and, in simple situations `if (x = y) { print x; }` [download] are ok, but `if (x = y) { print x; }` [download] is not. In this stripped down form I can see how the last example, although interpreted properly by Perl, can look like a random `if (x = y)` and an unrelated block of `{ print x; }`. I'm not entirely sure of what kind of examples you are asking for, but from this node: ... `if ($Age < 13) && ($Age > 0)) { print "What are you doing here, $firstName? This Web site is strictly PG-13. Shame on you for being so naughty as to come here!"; } elsif ($Age < 18) && ($Age > 12)) { print "Not to long ago, we’d have have chased you away from our Web site. But now that you’re a teenager and mature enough for PG-13 materials, we’re glad to see you $firstName."; }` [download] ... has the same qualities as my code and could be cleaned up (focusing on the indentation and curly braces) by saying: `if (($Age < 13) && ($Age > 0)) { print "content"; } elsif (($Age < 18) && ($Age > 12)) { print "content"; }` [download] or even: `if (($Age < 13) && ($Age > 0)) { print "content"; } elsif (($Age < 18) && ($Age > 12)) { print "content"; }` [download] Thank you again for taking time out to help me grasp the fundamentals. Please let me know if I am missing your point. I enjoy Perl (and learning programming in general) and feel I have been progressing rather quickly, but I want to squash bad habits and form a good foundation in style and understanding before moving to some of the more complex concepts and modules in Perl.	[reply] [d/l] [select]
Re^7: Regex help/ Lua parse by kcott (Archbishop) on Oct 28, 2012 at 07:42 UTC
Another book you may be interested is Perl Best Practices Standards and Styles for Developing Maintainable Code. Amongst all its other good advice, this has an entire chapter devoted to guidelines for code layout. Be aware that this book provides guidelines; not rules. Also, as it was released in 2005, it won't make references to features added in more recent versions of Perl (perlhist provides a history of Perl releases, if you're interested). -- Ken	[reply]