in reply to elsif statement not being evaluated

Hi jonagondos,
check this in your code: 

if ( $choice = $an2 ) {
 ...
}
elsif ( $choice = $an1 ) {
 ...
}

[download]
I suppose you want to use 
if ( $choice == $an2 ) {
 ...
}
elsif ( $choice == $an1 ) {
 ...
}

[download]
You are assigning to variable $choice, the value of the variable $ans2 using the assignment operator '=' .
So, whatsoever, value inputted was replaced by the value of variable $ans2.
In which case variable $choice value is ALWAYS evaluate to 2 the pre-defined value of variable $ans2, so your elsif(){...} statement is not being evaluated.

If you tell me, I'll forget.
If you show me, I'll remember.
if you involve me, I'll understand.
--- Author unknown to me

Replies are listed 'Best First'.
Re^2: elsif statement not being evaluated
by jonagondos (Novice) on Nov 18, 2012 at 06:29 UTC
    oh gosh i feel stupid... i was using the assignment operator
[reply]

      Happens to everyone using C or languages inheriting or stealing from C. But you can make the compiler / interpreter complain loudly if you make sure the constant is on the left side of the operator:

      if ($answer=42) { # $answer is now always 42
    ...
}


if (42=$answer) { # "Can't modify constant item in scalar assignment"
    ...
}

      [download]

      This won't help when you compare two variables, but in your case, the variables $an1 and $an2 aren't variable, but constant. So make them constant, either by using Readonly or by using constant:

      use Readonly;
Readonly my $fortytwo => 42; # note: =>, not =

...

if ($fortytwo=$answer) { # "Modification of a read-only value attempte
+d"
    ...
}

      [download]
      use constant FORTYTWO => 42; # note: =>, not =

...

if (FORTYTWO=$answer) { # "Can't modify constant item in scalar assign
+ment"
    ...
}

      [download]

      Or, in this trivial case, get rid of $an1 and $an2 and use 1 and 2.

      I prefer Readonly over constant, because Readonly just makes the variables readonly, with no surprises, whereas constant (ab)uses the perl optimizer and implements the constants as functions returning a constant value. This has some nasty side effects documented in Readonly.

      Alexander

      --
      Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
[reply]
[d/l]
[select]

      jonagondos,

      You're just human and new to Perl!

      And when you're an expert, just remember someone else will be 'new to Perl'!

      You're on your way...Ed

      "Well done is better than well said." - Benjamin Franklin

[reply]

        ... You're just human and new to Perl! ...

        Assumptions assumptions :)

[reply]

In Section Seekers of Perl Wisdom