in reply to Re: use Module and case-insensitive file names
in thread use Module and case-insensitive file names

Why would the filename put in %INC be the "proper" name? I would think it would use whatever the user typed, unless it somehow gets canonized during the search process?

Yup, it shows the name in the program, not the actual file name: 

[D:\download\public\Perl]perl -MData::Dumper -e "use cArP; print Dumpe
+r (\%%INC)"
VAR1 = {
         'Exporter.pm' => 'D:/Program Files/Perl-5.6/lib/Exporter.pm',
         'Carp.pm' => 'D:/Program Files/Perl-5.6/lib/Carp.pm',
         'XSLoader.pm' => 'D:/Program Files/Perl-5.6/lib/XSLoader.pm',
         'warnings/register.pm' => 'D:/Program Files/Perl-5.6/lib/warn
+ings/register.pm',
         'warnings.pm' => 'D:/Program Files/Perl-5.6/lib/warnings.pm',
         'overload.pm' => 'D:/Program Files/Perl-5.6/lib/overload.pm',
         'Data/Dumper.pm' => 'D:/Program Files/Perl-5.6/lib/Data/Dumpe
+r.pm',
         'cArP.pm' => 'D:/Program Files/Perl-5.6/lib/cArP.pm'
       };

[download]
Perhaps the right place would be in the code that searches @INC for the module? If it finds something that differs only in case, and it's a case-insentive OS, issue a warning and take the file name that was actually found, so things import properly.

I don't know why, but Data::Dumper for example just doesn't work if called DaTA::Dumper, even though there is no error of any kind.

—John

Replies are listed 'Best First'.
Re: Re: Re: use Module and case-insensitive file names
by japhy (Canon) on Jul 31, 2001 at 00:46 UTC
    Ok. I've changed my strategy: 
    if (
  running_under_windows
  and
  Foo.pm loaded
  and
  package_Foo doesn't exist
) { warn about case of Foo }

    [download]
    The reason that 
    use Strict;
$x = 10;

    [download]
    is valid is because use is merely: 
    BEGIN {
  require Strict;
  Strict->import;
}

    [download]
    And on Windows, require Strict goes through fine, thanks to the caseless OS. And import silently fails (as is documented).

    The DaTA::Dumper thing didn't give an error because you didn't turn on warnings. If warnings were on, you'd have seen: 

    Name "main::Dumper" used only once: possible typo at -e line 1.
Filehandle main::Dumper never opened at -e line 1.

    [download]

    _____________________________________________________
    Jeff japhy Pinyan: Perl, regex, and perl hacker.
    s++=END;++y(;-P)}y js++=;shajsj<++y(p-q)}?print:??;

[reply]
[d/l]
[select]
      Importing a non-existent package calls Universal::import rather than giving an error? Why do we want that behavior?

      It seems to me that something like you propose used to exist! I recall getting an error when the package didn't match the name. Maybe this was in there before, or still is but doesn't work anymore?

      If you warn that package_Foo doesn't exist after reading Foo.pm, that's a general warning that's good anywhere: the file may have been renamed, you might have fat-fingered the package line when writing it, it might be a symlink, etc. If you are going to make it windows-only, check that some package does exist that's a case mismatch, rather than the target just not existing. To make it complete, need a no warnings 'package_load' as well.

      —John

[reply]
[d/l]
        If you don't supply an import method for a package, it fails silently without warning. This goes for packages that... well... don't exist at all.

        Here's my code. I hope you understand most of it: 

        #ifdef WIN32
    if (strcmp(name + len - 3, ".pm")) {
        char *pkg;
        int slash_count = 0, i = 0;
        
        for (i = 0; i < len - 3; i++) {
            if (name[i] == '/') slash_count++;
        }

        /* "Foo/Bar.pm" + 1 (slash) - 3 (".pm") + 1 ("\0") */
        pkg = malloc(sizeof(char) * (len + slash_count - 3 + 1));
        
        slash_count = 0;
        
        for (i = 0; i < len - 3; i++) {
            if (name[i] == '/') {
                pkg[i + slash_count] = ':';
                pkg[i + ++slash_count] = ':';
            }
            else pkg[i + slash_count] = name[i];
        }
        pkg[i + slash_count] = '\0';
                
        if (!gv_stashpv(pkg, FALSE))   
            Perl_warner(aTHX_ WARN_MISC, "Package %s not found (did yo
+u use the incorrect case?)", pkg);
    }
#endif

        [download]

        _____________________________________________________
        Jeff japhy Pinyan: Perl, regex, and perl hacker.
        s++=END;++y(;-P)}y js++=;shajsj<++y(p-q)}?print:??;

[reply]
[d/l]

In Section Meditations