in reply to File::Find and replacing spaces in filenames.

Replies are listed 'Best First'.
Re^2: File::Find and replacing spaces in filenames.
by Kyshtynbai (Sexton) on Dec 22, 2012 at 17:36 UTC

    1. Well, that is a problem. I'm going to think about it tonight.

    2. like this return 1 if $_ !~ /\s+/; ?

    3. No, it won't; files to process are just photos which are just stored on hdd, no software refers to them.

    Thanks!
[reply]
[d/l]

      2. like this return 1 if $_ !~ /\s+/; ?

      No, because then you would have to perform a second match, which is unneeded. The s// operator returns the number of substitutions made, and 0 is perl's value for false.

      
    if ($_ =~ s/ /_/g) {
        # rename
    } else {
        return 1
    }

      [download]

      However, according to the docs for File::Find the return value of the wanted() function is ignored, so just write:

          if ($_ =~ s/ /_/g) {
        # rename
    }

      [download]
[reply]
[d/l]
[select]

        Thank you, now I get!

        Could you please tell why performing second match is bad? It can cause some errors? Or it spends resources of the machine? Or is it just a bad style of programming?
[reply]

In Section Seekers of Perl Wisdom