in reply to Re^3: Open a folder
in thread Open a folder

Hi blue cowdawg

I tried this:

#!/usr/bin/perl -w

use strict;
use warnings;

my $dir = 'C:\Users\ZB\Desktop\Text Files';
opendir (DIR, $dir) or die $!;

while (my $file = readdir(DIR))
{
    next if $file eq '.';
    next if $file eq '..';
    &countWords($dir, $file);    #call sub
}

sub countWords
{
    my $line = @_;        #receive file as input
    my @array = split(/ /, $line);
    print "$#array\n";
}

closedir(DIR);

[download]

It is the same thing as earlier, I just added a small sub which is supposed to parse each file into an array, count the words and print the output(total words). Did I call the sub correctly? And does the sub receive the file correctly? When I run the script it gives the same answer(total words) for each text file, which is incorrect.

Thank you

Replies are listed 'Best First'.
Re^5: Open a folder
by blue_cowdawg (Monsignor) on Jan 09, 2013 at 14:04 UTC
        And does the sub receive the file correctly? When I run the script it gives the same answer(total words) for each text file, which is incorrect.

    Professor Cowdawg just drew a red "X" across your assignment. 

    
sub countWords {
  my $fname=join("/",@_);
   
   open FIN,"< $fname" or die "$fname:$!";
   my @lines=<FIN>;
   chomp @lines;
   close FIN;
   my $count=0;
   foreach my $line(@lines){
       map { $count++ } split (/[\s\t\n]+/,$line);
   } 
   printf "There are %d words in %s\n",$count,$fname;
}

    [download]
    You are not counting anything in your sub at all. You actually have to read the file in order to count the words in it.

    Peter L. Berghold -- Unix Professional
    Peter -at- Berghold -dot- Net; AOL IM redcowdawg Yahoo IM: blue_cowdawg
[reply]
[d/l]

In Section Seekers of Perl Wisdom