Re^5: Install Math::GSL fail

I get the same errors on Mac OSx 10.8.2 and gcc 4.6.3 :

xs/Roots_wrap.1.15.c:3283:7: error: void function '_wrap_gsl_root_fdfs
+olver_fdf_set' should not return a value [-Wreturn-type]
      return (gsl_nan());
      ^      ~~~~~~~~~~~

...

xs/Roots_wrap.1.15.c:3840:7: error: void function '_wrap_gsl_root_fdfs
+olver_set' should not return a value [-Wreturn-type]
      return (gsl_nan());
      ^      ~~~~~~~~~~~
[download]

This thread is a bit old. I wonder if anybody has made any progress on this?

Comment on Re^5: Install Math::GSL fail Download Code

Replies are listed 'Best First'.
Re^6: Install Math::GSL fail by syphilis (Archbishop) on Jan 24, 2013 at 09:54 UTC
return (gsl_nan()); That looks wrong to me, too - I think that the value returned by gsl_nan() needs instead to be pushed onto the stack and returned using XSRETURN() ... but I don't have time to test, tonight. Cheers, Rob	[reply]
Re^7: Install Math::GSL fail by aixtal (Sexton) on Jan 24, 2013 at 10:14 UTC
Wonderful! Your reply opened my eyes. I changed the two occurrences of return to XSRETURN, and the build succeeded. I'll file a pull request on Github. Many thanks! --j	[reply]
Re^8: Install Math::GSL fail by syphilis (Archbishop) on Jan 25, 2013 at 07:38 UTC
I changed the two occurrences of return to XSRETURN, and the build succeeded Whilst that will enable the build to succeed, it's unfortunately not the right solution. XSRETURN() takes, as its argument, the number of elements to return from the stack. According to perldoc perlapi: `XSRETURN Return from XSUB, indicating number of items on the stack. This is u +sually handled by "xsubpp". void XSRETURN(int nitems)` [download] I'm not sure what will happen if your version of that block of code gets executed and an attempt is made to return gsl_nan() items off the stack ... but I fully expect that it won't be pretty. If that block of code gets executed, then it needs to XSRETURN(1), and the one item that it needs to return from the stack is whatever-it-is-that-is-returned-by gsl_nan(). (Presumably that's either a NaN, or a Math::GSL object that holds the value NaN.) So long as that block of code never gets executed I think your fix should, however, be fine. Cheers, Rob	[reply] [d/l]
Re^6: Install Math::GSL fail by Anonymous Monk on Jan 24, 2013 at 09:45 UTC
This thread is a bit old. I wonder if anybody has made any progress on this? Progress such as?	[reply]
Re^7: Install Math::GSL fail by aixtal (Sexton) on Jan 24, 2013 at 09:56 UTC
Such as a fix or workaround	[reply]
Re^8: Install Math::GSL fail by Anonymous Monk on Jan 24, 2013 at 10:25 UTC
Such as a fix or workaround Workaround? You don't mean so the module can install with failing tests, do you? Well, the bug was reported ( rt://Math-GSL ) ... :)	[reply]