Re: subs && typeglobs

tachyon, that is fine and dandy and I appreciate the code :) but I am more into figuring out why the problem exists, therefore I can better appreciate the solution to the problem.

dir_search(*D,"$path$cont");
[download]

this seems to be where all the trouble lies, everything previous to this line works as expected. Actually the whole script runs without errors under perl -c it just doesn't do the recursion that I was expecting. To clarify what I'm asking: I want to know why my code doesn't work :)

#!/usr/bin/perl -w
#
##
use strict;
my $Spath='/home/s0ttlen/';

opendir(H, "$Spath")|| die "Error:$!\n";
dir_search(*H,"$Spath");

sub dir_search{
     local(*ROOT)=$_[0];
     my $path=$_[1];
     my $cont;
     foreach $cont (sort readdir(ROOT)){
        next if $cont eq '.' or $cont eq '..';
        next if -l "$path$cont";
        if (-f "$path$cont"){
           &log("$path$cont") if (-T "$path$cont" || -u "$path$cont");
        }
        elsif (-d "$path$cont" && opendir(D,"$path$cont")) {
           dir_search(*D,"$path$cont");
        } 
     }
}

sub log{
     my $file=$_[0];
     my $log='/home/s0ttlen/log/slog';
     open(LOG,">>$log")|| die "Error:$!\n";
     print LOG "$file\n";
}
[download]

Comment on Re: subs && typeglobs Select or Download Code

Replies are listed 'Best First'.
Re: Re: Re: Re: Re: subs && typeglobs by tachyon (Chancellor) on Aug 04, 2001 at 14:49 UTC
OK here are a couple of debugging print statements that show you why your code fails. The reason is you forget to add the directory separator as you recurse - as a result you do not search a valid path on your first recursion. See my code to see this happening - when you get a dir back from readdir it is called mydir not mydir/ as your code expects, add the / as shown and it will work. my $Spath='c:/cluster1/'; opendir(H, "$Spath")\|\| die "Error:$!\n"; dir_search(H,"$Spath"); sub dir_search{ local(ROOT)=$_[0]; my $path=$_[1]; print "path $path\n"; my $cont; foreach $cont (sort readdir(ROOT)){ print " $path$cont\n"; next if $cont eq '.' or $cont eq '..'; next if -l "$path$cont"; if (-f "$path$cont"){ &log("$path$cont") if (-T "$path$cont" \|\| -u "$path$cont"); } elsif (-d "$path$cont" && opendir(D,"$path$cont")) { dir_search(D,"$path$cont"); # dir_search(D,"$path$cont/"); <<-- this / is what you nee +d } } } [download] cheers tachyon s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print	[reply] [d/l]
Re: subs && typeglobs by s0ttle (Scribe) on Aug 04, 2001 at 15:41 UTC
sweet savior :) Thanks guy.	[reply]