If statement multiple conditions

kbone has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: If statement multiple conditions by choroba (Cardinal) on Mar 13, 2013 at 23:11 UTC
Works for me. Can you show what really is in $cik and @ciks, for example by inserting the following before the if line: `use Data::Dumper; $Data::Dumper::Useqq = 1; warn Dumper $cik, \@ciks;` [download] لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ	[reply] [d/l]
Re^2: If statement multiple conditions by kbone (Novice) on Mar 14, 2013 at 00:47 UTC
Thank you for your quick reply! The @ciks array is one I created from a text file. I have printed it at certain points in the program and it seems to work. The $cik variable is one that is generated in the program. Here is the full story: I have a list of identifiers whose SEC filings I want to download. If I do not specifically select those firms, I have to download the entire list from that server, which takes several hours per year. The way this process works is that there is an index file that lists every file available for a given fiscal quarter. In essence, the $cik is the firm identifier from the index file. I only want a certain file type from certain firms...this is what I am trying to match. When I use that code you provided when you asked what was in $ciks and @ciks it runs without stopping...seems to repeat over and over again what is in the @ciks array. Thanks again for your help!	[reply]
Re^2: If statement multiple conditions by kbone (Novice) on Mar 14, 2013 at 01:19 UTC
If I use $cik==@ciks[0], I get the single match I am looking for. I am sure this is a minor error that I am just not seeing.	[reply]
Re^3: If statement multiple conditions by choroba (Cardinal) on Mar 14, 2013 at 09:21 UTC
`==` is used to compare numbers in Perl. If your data contain strings, you should use `eq` instead. لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ	[reply] [d/l] [select]
Re: If statement multiple conditions by Kenosis (Priest) on Mar 13, 2013 at 23:55 UTC
Are there any meta-characters in `$formget` that may interfere with the match? If so, consider trying `$form_type=~/\Q$formget\E/`	[reply] [d/l] [select]
Re^2: If statement multiple conditions by kbone (Novice) on Mar 14, 2013 at 00:50 UTC
The form type variable does have a .* in it. I tried your suggestion and I still could not pull any matches. I think it must have something to do with how I have set up the array. Thanks for your response!	[reply]
Re^3: If statement multiple conditions by Kenosis (Priest) on Mar 14, 2013 at 02:46 UTC
You're most welcome, kbone!	[reply]
Re: If statement multiple conditions by locked_user sundialsvc4 (Abbot) on Mar 14, 2013 at 01:45 UTC
There are a couple of things that I do “routinely,” partly (but also, specifically) to guard against those WTF?!?! situations ... First, in every script, I use `use strict; use warnings;`. If you’ve omitted these, add them, run it again and see what happens. Second, I will either use nested-`if` statements, or, when doubling up several conditions, I put each one in a separate set of parentheses whether I think I need them or not. I candidly confess that I intentionally do not use “smart matching” (`~~`) either, although I won’t say that you should or shouldn’t. I just prefer code that says as plainly as possible (to my feeble old brain) what it means, versus code that says what it says and depends on context to provide what it means. If I have to read several paragraphs of `perldoc perlsyn` to fathom what something means, and to be warned that Perl-6 will be different, I don’t do it that way.
Re^2: If statement multiple conditions by kbone (Novice) on Mar 14, 2013 at 02:50 UTC
Thanks for the reply!	[reply]
Re: If statement multiple conditions (stumped? checklist) by Anonymous Monk on Mar 14, 2013 at 00:20 UTC
but I am stumped Great, there are checklists for that , Basic debugging checklist , brian's Guide to Solving Any Perl Problem, CGI Help Guide , Troubleshooting Perl CGI scripts	[reply]
Re: If statement multiple conditions by aitap (Curate) on Mar 14, 2013 at 19:11 UTC
Consider using hashes instead of arrays when you are checking for existense or counting something: `my %ciks_hash; undef @ciks_hash{@ciks}; # this is called "hash slice" # ... later: if ($form_type=~/$formget/i && exists $ciks_hash{$cik}) { ... }` [download] See also: Slices, How can I remove duplicate elements from a list or array? Sorry if my advice was wrong.	[reply] [d/l]