Re^5: REVISED - Transforming File Name Characters

If $dir/$new already exists, you do not rename it. That's not what I think you want. What about this:

sub fixdir {
    my $dir = shift;
    opendir my $DH, $dir or die "Cannot open '$dir': $!";

    while (my $f = readdir $DH) {
        next if grep $_ eq $f, qw/. ../;
        (my $new = $f) =~ s/[^a-zA-Z0-9_.]/_/g;
        if ($new ne $f) {
            $new .= '1' while -e "$dir/$new";

            print STDERR "Renaming: $f -> $new\n";
            rename "$dir/$f", "$dir/$new"; 
        }

        fixdir("$dir/$new") if -d "$dir/$new";
    }
}
[download]

لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ

Comment on Re^5: REVISED - Transforming File Name Characters Download Code

Replies are listed 'Best First'.
Re^6: FINAL - Transforming File Name Characters by rfleisch (Initiate) on Mar 15, 2013 at 15:18 UTC
And this is my FINAL results. I tested it on TWO LARGE folders and it worked great. And YES, I backed up first. :-) I thank you Sooooooooo Much -Regards -Ray #!/usr/bin/perl # use POSIX qw/strftime/; # use strict; # use warnings; # use diagnostics; sub fixdir { my $dir = shift; opendir my $DH, $dir or die "Not Found....$dir: $!"; while (my $f = readdir $DH) { next if grep $_ eq $f, qw/. ../; fixdir("$dir/$f") if -d "$dir/$f"; (my $new = $f) =~ s/[^a-zA-Z0-9_.]/_/g; if ($new eq $f) { next; } while ( -e "$dir/$new") { $new .= "1"; } print STDERR "Renaming: $f -> $new\n"; rename "$dir/$f", "$dir/$new"; } } die "No command line arguments given!" unless @ARGV; my $nargs = @ARGV; print "Number of command line arguments is $nargs\n"; my $Do_Dir = $ARGV[0]; # print("ARG=", "$Do_Dir", "<<<<<<\n"); if (!$Do_Dir ) { print ("No Folder Name given!\n"); exit; } print( "The Folder Name is: ", "$Do_Dir", "\n" ); fixdir("$Do_Dir"); print "Done...\n" [download]	[reply] [d/l]

Replies are listed 'Best First'.

Re^6: FINAL - Transforming File Name Characters
by rfleisch (Initiate) on Mar 15, 2013 at 15:18 UTC

I thank you Sooooooooo Much


#!/usr/bin/perl

# use POSIX qw/strftime/;
# use strict;
# use warnings;
# use diagnostics;

sub fixdir {
    my $dir = shift;
    opendir my $DH, $dir or die "Not Found....$dir: $!";
    while (my $f = readdir $DH) {
        next if grep $_ eq $f, qw/. ../;
        fixdir("$dir/$f") if -d "$dir/$f";
        
        (my $new = $f) =~ s/[^a-zA-Z0-9_.]/_/g;

        if ($new eq $f) { next; }
        
        while ( -e "$dir/$new") { $new .= "1";  }

        print STDERR "Renaming: $f -> $new\n";
        rename "$dir/$f", "$dir/$new"; 
    }
}

die "No command line arguments given!" unless @ARGV;

my $nargs = @ARGV;
print "Number of command line arguments is $nargs\n";

my $Do_Dir = $ARGV[0];
# print("ARG=", "$Do_Dir", "<<<<<<\n");
if (!$Do_Dir ) {
    print ("No Folder Name given!\n");
    exit; }
print( "The Folder Name is: ", "$Do_Dir", "\n" );
fixdir("$Do_Dir");
print "Done...\n"
[download]

[reply]
[d/l]