in reply to Splitting a text file

Hi,

you are already on the right track. You might try to adapt your algorithm as follows (to keep most of your ideas/code)

Hope that helps! Rata

Replies are listed 'Best First'.
Re^2: Splitting a text file
by Dr Manhattan (Beadle) on Mar 20, 2013 at 05:05 UTC

    Hi all

    I tried this and it seems to be working fine

    my $length = $#array;
my $fileNR = 1;

for (my $x = 0; $x < $length; $x++)
{
    open ($fileNR, ">$fileNR.txt") or die "can't open";
    print $fileNR "$array[$x]\n";
    
    if ($x % 1000 == 999)
    {
        close ($fileNR);
        $fileNR++;
    }
}

    [download]

    Except that it doesn't print line 1 - 1000 to a file(as it should do), it just prints every 1000th line in a file, and then it goes on to the next file. Any idea why this happens?

[reply]
[d/l]

      Hi Dr Manhattan,

      have a look at the difference between my algorithm and your solution: you open the file in each iteration of the loop. And by opening a file for writing, you erase the previous content.

      The solution is to open the file before the loop. And (additionally) inside the if-block, when you want to switch to the next file.

      HTH, Rata
[reply]
[d/l]

In Section Seekers of Perl Wisdom