$sth = $dbh->prepare( $SQL );
$sth->execute();
@header_ID = $sth->fetchrow_array();
[download]

1. don't be afraid to use whitespace:

$header_id = $dbh->prepare("
  SELECT id 
  FROM press_release
  WHERE header = ?
");
[download]

2. Use bind variables instead of interpolated statements. If this statement is to be executed again and again, using bind variables will increase performance. So, how do you tell DBI what the value of the question mark is? Inside the execute function:

$header_id->execute($header);
[download]

jeffa

In addition to the comments that jeffa made regarding the performance benefits of using placeholders in DBI statements (the question mark), I'd like to mention something else about them.

Using bind variables can also plug up significant security holes. Imagine what happens if someone using the program manages to set $header to the following:

foo';DROP TABLE press_release;SELECT * FROM press_release WHERE header
+='foo
[download]

For databases that allow multiple SQL statements separated by semi-colons, this is how the SQL gets interpreted:

SELECT id FROM press_release WHERE header = 'foo';
DROP TABLE press_release;
SELECT * FROM press_release WHERE header='foo'
[download]

The last statement is a throwaway, but because the cracker has taken the time to balance the quotes, the database will happily attempt to execute all of the SQL statements. These may or may not succeed (depending upon permissions, foreign key constraints, etc.), but a cracker should never get this close to touching the database. Placeholders, in addition to benefitting performance, also plug this potentially huge security hole.

You can also protect yourself with the following changes:

$header    = $dbh->quote( $header );

# note the *lack* of single quotes around $header
$header_id = $dbh->prepare("SELECT id FROM press_releases WHERE header
+ = $header");
[download]

This works, but there are two problems with it:

1. You lose the performance benefits of using placeholders and bind variables.
2. It's easy to forget to quote the variable.

Stick with placeholders and your scripts will be much more secure.

Cheers,
Ovid

Vote for paco!

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

( my $header_id_num ) = $header_id->fetchrow_array;

For records with more fields, I'm partial to fetchrow_hashref:

my $record = $header_id->fetchrow_hashref;
my $header_id_num = $record->{ 'id' };
[download]

As an aside, if you're not doing so already, I strongly recommend that you check the error status of your prepare and execute statements. It's saved my rear many a time.

$header_id = $dbh->prepare( $sql_command ) || die $dbh->errstr;
$header_id->execute || die $dbh->errstr;
[download]

(Or use whatever you want in place of die...)

Note that the fetchrow returning 0 might just mean that you're at the end of a record, so you shouldn't check for errors there. I believe there is an error flag that is raised if your fetch fails for other reasons. Check the DBI docs for more info.

elbieelbieelbie